Skip to content

introduce pat-update event factory, use it in basepattern, emit after validation checks. #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2025

Conversation

thet
Copy link
Member

@thet thet commented May 6, 2025

@thet thet force-pushed the validation-upds branch 2 times, most recently from 6e8d11e to b28d9ec Compare May 8, 2025 07:07
@thet thet requested a review from petschki May 8, 2025 07:15
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have in depth knowledge of the patternslib event machinery. Made a small code change suggestion though.

thet added 2 commits May 8, 2025 14:16
…instances to easily emit a pat-update event and already fill the most important properties. Expects an optional action parameter and an optional options object.
@thet thet force-pushed the validation-upds branch from f7a6372 to 2c15de1 Compare May 8, 2025 12:17
@thet thet merged commit 0c3e245 into master May 8, 2025
1 check passed
@thet thet deleted the validation-upds branch May 8, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants